Perform Proxy logic more like cURL #4616
Open
+996
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3904
Types of changes
Introduces a helper function
getProxyForUrl
that computes the proxy to use based on Env Vars and options provided in accordance with the discussion and linked articles in the issueProxy Variables Handling:
Proxy Environment Variables:
NPM Proxy Configuration:
Works with
npm_config_http_proxy
,npm_config_https_proxy
,npm_config_proxy
,npm_config_no_proxy
.Handles precedence of NPM proxy configurations over environment variables like HTTP_PROXY, HTTPS_PROXY, NO_PROXY.
Overall, the "Proxy Helper" function effectively handles various proxy configurations and environment variables, providing consistent and expected results according to the specified configurations.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Proposed changes
NR_PROXY_MODE
(setting tolegacy
reverts functionality)TODO
NR_PROXY_MODE
Checklist
npm run test
to verify the unit tests pass