Replacing vm.createScript in favour of vm.Script

[patlux]

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Proposed changes

It seem's vm.createScript is deprecated, because it's not mentioned in the official docs. This PR replaces vm.createScript by vm.Script.

This was needed by myself to run node-red with bun.sh. vm.createScript is not available in bun, because I think they missed it due of the missing documentation? Not sure.

The advantage of running node-red with bun is support of esm :)

I also opened a PR there to add support for vm.createScript: oven-sh/bun#8312

Checklist

• I have read the contribution guidelines
• For non-bugfix PRs, I have discussed this change on the forum/slack team.
• I have run npm run test to verify the unit tests pass
• I have added suitable unit tests to cover the new/changed functionality

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: patlux / name: Patrick Wozniak (a587655, ec062d0, f83174c, 2890708)

[Steve-Mcl]

This was needed by myself to run node-red with bun.sh. vm.createScript is not available in bun, because I think they missed it due of the missing documentation? Not sure.

NodeJS has not documented createScript since Node V0.12 (24 Nov 2015)

It seem's vm.createScript is deprecated, because it's not mentioned in the official docs. This PR replaces vm.createScript by vm.Script.

My guess is that it was simply undocumented while node was still in beta/pre V1. (tho it is odd that they have kept it around!)

---

PS: Since you are playing with bun, be aware there is a major problem with GOT (the http request library we use under the hood) + Bun.
You will crash node-red with the exception "A retry listener has been attached already" when attempting to do HTTP requests.

It doesnt look like a quick fix nor does it look like GOT or BUN are in any hurry to resolve it.

• Bun throws error 'A retry listener has been attached already' sindresorhus/got#2299
• feat(compat): support got oven-sh/bun#4395

[patlux]

PS: Since you are playing with bun, be aware there is a major problem with GOT (the http request library we use under the hood) + Bun.

You will crash node-red with the exception "A retry listener has been attached already" when attempting to do HTTP requests.

Sadly yes, I discovered the error just after I created this PR ;(

Switched back to node for now.

[knolleary]

Thanks for this. Given the node.js (undocumented) implementation of createScript is to simply delegate to new Script() this appears to be a pretty sensible change to make.