Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2429 localizing a node status message #4428

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dumdiedum
Copy link

Second attempt...

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This PR introduces the params property to the status object within Node-RED's node API, enhancing the way status messages can be parameterized. This addition allows developers to send structured data alongside status text, facilitating more complex interactions and status handling in flows.

The type definitions for the Monaco Editor have been updated to include the new params property in a separate PR, please see here.

If this PR is accepted, the official documentation will need to be updated to reflect the new params property within the status object.

Thank you for considering this contribution. I look forward to your feedback and any further actions required on my part.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

…ams object in status event in red.js. added test for handleStatusEvent with params for comms.js
@Steve-Mcl
Copy link
Contributor

Once merged, review this: node-red/nr-monaco-build#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants