Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc code improvements #4356

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

hlovdal
Copy link

@hlovdal hlovdal commented Sep 19, 2023

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Remove unused code, whitespace fixes for the files I edited and added .ackrc file since by default
ack ignores node_modules which is not applicable for this repository.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Copy link
Member

@dceejay dceejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most look good/trivial to me so ok. Will need @knolleary to comment on updateMissingTypes in case he has plans for that.

Not sure we need the .ackrc file - you can add it to a directory above where you clone the repo to (eg a Projects dir and it would then apply automatically to any paths underneath. So not sure we need it in this project specifically. (But if we did then we could add --sort-files to make it more consistent)

@knolleary
Copy link
Member

No issue with most of these changes, however not sure we want to add .ackrc to the project. We tend to only include config files for the things actively used by the project and don't want to set an expectation we'll include config files for any and all tools out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants