Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove outdated Node 11+ check #4314

Merged
merged 1 commit into from May 14, 2024
Merged

fix: remove outdated Node 11+ check #4314

merged 1 commit into from May 14, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 5, 2023 •
edited

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Remove outdated NodeJS version checks because they are not supported anymore.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Reference

#4687

@knolleary knolleary added this to the 4.0 milestone Jan 19, 2024
@Rotzbua Rotzbua changed the title Remove outdated node check Remove outdated node <16 checks Feb 19, 2024
@Rotzbua Rotzbua changed the title Remove outdated node <16 checks Remove outdated node <18 checks Feb 19, 2024
@Rotzbua Rotzbua marked this pull request as draft May 12, 2024 20:34
@Rotzbua Rotzbua force-pushed the remove_outdated_node_check branch from 30c936d to b361960 Compare May 12, 2024 20:50
@Rotzbua Rotzbua force-pushed the remove_outdated_node_check branch from b361960 to d706c9c Compare May 12, 2024 20:51
@Rotzbua Rotzbua changed the title Remove outdated node <18 checks fix: remove outdated Node 11+ check May 12, 2024
@Rotzbua Rotzbua marked this pull request as ready for review May 12, 2024 20:55
@Rotzbua Rotzbua requested a review from ko1ebayev May 12, 2024 20:55
@Rotzbua
Copy link
Contributor Author

Rotzbua commented May 12, 2024

Rebased and split PR for easier review.

@knolleary knolleary merged commit d520cde into node-red:dev May 14, 2024
3 checks passed
@Rotzbua Rotzbua deleted the remove_outdated_node_check branch May 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@ko1ebayev ko1ebayev Awaiting requested review from ko1ebayev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rotzbua @knolleary @ko1ebayev