New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.2 Chinese translation update and fix errors in tags in html files #4245
base: master
Are you sure you want to change the base?
Conversation
Node v3.0.2 Chinese translation
fix error type
fix error type
fix error type
Replaces instances of `:` with proper colons `: ` Replaces instances of `,` with proper commas `, `
Hi @XuyuEre Thank you for this contribution. Unfortunately we do not speak Chinese. Do you have any Chinese speaking developer friends or associates who could review this pull request? @JiyeYu, @xiuqi08 would either of you guys be able to review these translations? Additionally, please be be sure to use a code editor (e.g. VSCode) for editing JSON files as your edits to `` corrupted the JSON due to :
I have fixed this file for you to get the tests passing. How a good code editor with JSON validation appears (VSCode): |
@Steve-Mcl Hey, I think I'd like to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the consistent script type type= "text/html"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed incorrect code tags; content in code tags does not need translation; modified some syntax that is more suitable for Chinese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use words that have been translated in v3.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
80-template.html
89-delay.html
89-trigger.html
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve translation
fullmooooon@5a9a959
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 74 corresponds to English translation line 89
fullmooooon@77576e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not translate 'message'; improve translation
fullmooooon@6a6ed3c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore changed msg.payload half width period
XuyuEre@743c5d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
work done
Now we need someone with write access to merge this PR
XuyuEre#1
And avoid modifying messages.json
packages/node_modules/@node-red/nodes/locales/zh-CN/messages.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3952
I originally wanted to make some changes to this file, but I just realized that it has been updated by someone after 'fork', and that version is better without over translation.
So, I think it's better not to modify this messages.json file and use the current version on v3.1.0 instead
v3.0.2 Chinese translation update and fix errors in tags in html files
Proposed changes
Checklist
grunt
to verify the unit tests pass