Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.2 Chinese translation update and fix errors in tags in html files #4245

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

XuyuEre
Copy link
Contributor

@XuyuEre XuyuEre commented Jul 10, 2023

v3.0.2 Chinese translation update and fix errors in tags in html files

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl
Copy link
Contributor

Hi @XuyuEre

Thank you for this contribution.

Unfortunately we do not speak Chinese. Do you have any Chinese speaking developer friends or associates who could review this pull request?

@JiyeYu, @xiuqi08 would either of you guys be able to review these translations?


Additionally, please be be sure to use a code editor (e.g. VSCode) for editing JSON files as your edits to `` corrupted the JSON due to :

  • instances of instead of proper colons :
    • _colon has an ascii value of 0x3A (58 decimal)
  • instances of with proper commas ,
    • comma has an ascii value of 0x2C (44 decimal)

I have fixed this file for you to get the tests passing.

How a good code editor with JSON validation appears (VSCode):
image

@fullmooooon
Copy link

@Steve-Mcl Hey, I think I'd like to do it.
I want to promote this PR because of the current comparison of the original v3.1.0 English text, there are some missing contents in the Chinese translation.
For example, the "help" of "mqtt in" does not mention "Inputs" at all.
I've never done "review" on github before.
Can you give me some guidance?
Or do I just need to skim through the changes with reference to the original translation?

Copy link

@fullmooooon fullmooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the consistent script type type= "text/html"

@fullmooooon
Copy link

XuyuEre#1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed incorrect code tags; content in code tags does not need translation; modified some syntax that is more suitable for Chinese

XuyuEre#1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use words that have been translated in v3.1.0

fullmooooon@5112bb7

Copy link

@fullmooooon fullmooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

80-template.html
89-delay.html
89-trigger.html
LGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve translation
fullmooooon@5a9a959

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 74 corresponds to English translation line 89
fullmooooon@77576e2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not translate 'message'; improve translation
fullmooooon@6a6ed3c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore changed msg.payload half width period
XuyuEre@743c5d5

Copy link

@fullmooooon fullmooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work done
Now we need someone with write access to merge this PR
XuyuEre#1
And avoid modifying messages.json
packages/node_modules/@node-red/nodes/locales/zh-CN/messages.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3952
I originally wanted to make some changes to this file, but I just realized that it has been updated by someone after 'fork', and that version is better without over translation.
So, I think it's better not to modify this messages.json file and use the current version on v3.1.0 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants