Add editor scope to keyboard shortcut scope select #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4140
The keyboard shortcut dialog doesn't provide all of the available 'scopes' when setting custom keyboard shortcuts.
This makes it impossible to add a shortcut scoped to just the edit dialog - something that can be done via keymap.json as it can specify any scope it wants.
This PR adds 'edit dialog' as an option when setting the shortcut scope:
This then allows 'escape' to be set as the shortcut for closing the tray, without it clashing with the existing predefined escape handler for clearing the selection within the workspace.