Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding STT support for email node #230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wajnberg
Copy link

@wajnberg wajnberg commented Sep 5, 2016

Signed-off-by: Moshe Wajnberg wajnberg@il.ibm.com

Signed-off-by: Moshe Wajnberg <wajnberg@il.ibm.com>
@wajnberg
Copy link
Author

wajnberg commented Sep 5, 2016

Hello @knolleary

Could you please review this very simple change ?

Thank you

@coveralls
Copy link

coveralls commented Sep 5, 2016

Coverage Status

Coverage remained the same at 76.566% when pulling a61fda4 on wajnberg:master into f70cd1d on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.566% when pulling a61fda4 on wajnberg:master into f70cd1d on node-red:master.

@dceejay
Copy link
Member

dceejay commented Sep 5, 2016

We need to be extra careful with non-core nodes, as they could be installed on versions of Node-RED without the required patches... Will this break them ?

Signed-off-by: Moshe Wajnberg <wajnberg@il.ibm.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.566% when pulling 9992898 on wajnberg:master into f70cd1d on node-red:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.566% when pulling 9992898 on wajnberg:master into f70cd1d on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.566% when pulling 9992898 on wajnberg:master into f70cd1d on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.566% when pulling 9992898 on wajnberg:master into f70cd1d on node-red:master.

@coveralls
Copy link

coveralls commented Sep 18, 2016

Coverage Status

Coverage decreased (-0.03%) to 76.537% when pulling f502749 on wajnberg:master into f70cd1d on node-red:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants