Using cache for load function #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this module to write flow test as well. However, It takes long time to complete
redNodes.startFlowsin helper.load function when a flow file is big.I created a big flow.json in this PR and it takes about 300 ms for load function for each test. If there are 100 test cases for the flow it takes 30 seconds.
However, most test cases can use exactly the same setting and they don't have to call load function again. Therefore, I introduced cache.
I applied this changes to my project that has about 10 flow files and existing tests works without any change.
I want to merge this change if it still follow the concept of this module.