Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OutgoingHttpHeader type from @types/node #1779

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use OutgoingHttpHeader type from @types/node #1779

wants to merge 1 commit into from

Conversation

Semigradsky
Copy link

Purpose

Fixing incompatibility issue between HeadersInit and OutgoingHttpHeaders.

Changes

Use OutgoingHttpHeader type from @types/node

Additional information

In fact users can pass array of header values and header vaue as number, but TS users can't.

  • I updated readme
  • I added unit test(s)
  • fix #000

@Semigradsky
Copy link
Author

Also TS users now will have autocomplete for record-style headers.
image

Any string header name still available.

LinusU
LinusU approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

@Semigradsky Semigradsky marked this pull request as draft October 2, 2023 12:14
@Semigradsky
Copy link
Author

Looks like passing array working incorrectly, I will recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Semigradsky @LinusU