Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove header sorting when iterates over it #1662

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove header sorting when iterates over it #1662

wants to merge 2 commits into from

Conversation

JVBorges
Copy link

Purpose

Keep headers order while sending them.

Changes

Remove sorting function when iterates over it.

  • I updated readme
  • I added unit test(s)

@paulodiovani
Copy link

This is a small fix that does not change the behavior of the library, but since sorting the headers does not help with anything, it is a welcome change anyway, IMO.

Note: the Host header is included by node itself (https://github.com/nodejs/node/blob/6adaf23c20acc48b836134ea660dc8c16f028117/lib/_http_client.js#L283-L300) (pointed by @alexandresaura).

@nvspradeep nvspradeep mentioned this pull request Oct 29, 2022
Open
Somberor
Somberor approved these changes Nov 22, 2022
View reviewed changes
Copy link

@Somberor Somberor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept this merge very needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Somberor Somberor Somberor approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep headers order while sending them
3 participants
@JVBorges @paulodiovani @Somberor