Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nc fix: disable undo redo if expanded form is open #8509

Merged
merged 3 commits into from
May 17, 2024
Merged

Nc fix: disable undo redo if expanded form is open #8509

merged 3 commits into from
May 17, 2024

Conversation

rameshmane7218
Copy link
Collaborator

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 17, 2024 •
edited

Walkthrough

Walkthrough

The recent updates across multiple components and utilities in the nc-gui package primarily introduce a new condition for handling keydown events. The condition checks if an expanded form is open using the newly added isExpandedFormOpen() function. This ensures that event handling logic is more context-aware, preventing unintended actions when an expanded form is active.

Changes

Files Summary
.../components/cell/DatePicker.vue
.../DateTimePicker.vue
.../TimePicker.vue
.../YearPicker.vue		 Updated keydown event handling logic to include a check for isExpandedFormOpen().
.../composables/useUndoRedo.ts Modified keydown event condition to include isExpandedFormOpen() in the useUndoRedo composable.
.../utils/browserUtils.ts Added a new exported function isExpandedFormOpen to check for the presence of an expanded form.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bccf606 and f6b2dd7.
Files selected for processing (6)
  • packages/nc-gui/components/cell/DatePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/DateTimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/TimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/YearPicker.vue (1 hunks)
  • packages/nc-gui/composables/useUndoRedo.ts (1 hunks)
  • packages/nc-gui/utils/browserUtils.ts (1 hunks)
Additional comments not posted (5)
packages/nc-gui/components/cell/YearPicker.vue (1)

179-179: The updated keydown event handling logic correctly incorporates the check for an expanded form being open.

packages/nc-gui/composables/useUndoRedo.ts (1)

170-170: The inclusion of isExpandedFormOpen() in the undo/redo keydown event handler aligns with the PR's objectives and is implemented correctly.

packages/nc-gui/components/cell/TimePicker.vue (1)

188-188: The updated keydown event handling logic in the TimePicker component correctly incorporates the check for an expanded form being open.

packages/nc-gui/components/cell/DatePicker.vue (1)

208-208: The updated keydown event handling logic in the DatePicker component correctly incorporates the check for an expanded form being open.

packages/nc-gui/components/cell/DateTimePicker.vue (1)

272-272: The updated keydown event handling logic in the DateTimePicker component correctly incorporates the check for an expanded form being open.

packages/nc-gui/utils/browserUtils.ts Show resolved Hide resolved
@o1lab o1lab force-pushed the nc-fix/expanded-form-undo-redo branch 2 times, most recently from 76c0e05 to 2717be3 Compare May 17, 2024 11:00
coderabbitai[bot]
coderabbitai bot reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f6b2dd7 and 76c0e05.
Files selected for processing (6)
  • packages/nc-gui/components/cell/DatePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/DateTimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/TimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/YearPicker.vue (1 hunks)
  • packages/nc-gui/composables/useUndoRedo.ts (1 hunks)
  • packages/nc-gui/utils/browserUtils.ts (1 hunks)
Files skipped from review as they are similar to previous changes (6)
  • packages/nc-gui/components/cell/DatePicker.vue
  • packages/nc-gui/components/cell/DateTimePicker.vue
  • packages/nc-gui/components/cell/TimePicker.vue
  • packages/nc-gui/components/cell/YearPicker.vue
  • packages/nc-gui/composables/useUndoRedo.ts
  • packages/nc-gui/utils/browserUtils.ts

coderabbitai[bot]
coderabbitai bot reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 76c0e05 and 2717be3.
Files selected for processing (6)
  • packages/nc-gui/components/cell/DatePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/DateTimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/TimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/YearPicker.vue (1 hunks)
  • packages/nc-gui/composables/useUndoRedo.ts (1 hunks)
  • packages/nc-gui/utils/browserUtils.ts (1 hunks)
Files skipped from review as they are similar to previous changes (6)
  • packages/nc-gui/components/cell/DatePicker.vue
  • packages/nc-gui/components/cell/DateTimePicker.vue
  • packages/nc-gui/components/cell/TimePicker.vue
  • packages/nc-gui/components/cell/YearPicker.vue
  • packages/nc-gui/composables/useUndoRedo.ts
  • packages/nc-gui/utils/browserUtils.ts

@o1lab o1lab force-pushed the nc-fix/expanded-form-undo-redo branch from 2717be3 to 30716b3 Compare May 17, 2024 12:18
coderabbitai[bot]
coderabbitai bot reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2717be3 and 30716b3.
Files selected for processing (6)
  • packages/nc-gui/components/cell/DatePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/DateTimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/TimePicker.vue (1 hunks)
  • packages/nc-gui/components/cell/YearPicker.vue (1 hunks)
  • packages/nc-gui/composables/useUndoRedo.ts (1 hunks)
  • packages/nc-gui/utils/browserUtils.ts (1 hunks)
Files skipped from review as they are similar to previous changes (6)
  • packages/nc-gui/components/cell/DatePicker.vue
  • packages/nc-gui/components/cell/DateTimePicker.vue
  • packages/nc-gui/components/cell/TimePicker.vue
  • packages/nc-gui/components/cell/YearPicker.vue
  • packages/nc-gui/composables/useUndoRedo.ts
  • packages/nc-gui/utils/browserUtils.ts

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited

Uffizzi Preview deployment-51902 was deleted.

@mertmit mertmit merged commit f01d99f into develop May 17, 2024
23 checks passed
@mertmit mertmit deleted the nc-fix/expanded-form-undo-redo branch May 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@mertmit mertmit mertmit approved these changes

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rameshmane7218 @mertmit @dstala