Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin setting for minio CDN endpoint support #7305

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

li2go
Copy link

@li2go li2go commented Dec 27, 2023

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

For some well-known reasons, we usually do not use the standard endpoint/bucket/key mode to access resource files.

image
Solve this problem by adding a setting that will use the CDN address when necessary for resource display.
By applying this setting, it is possible to alleviate the implementation difficulties of some other compatible solutions.

Anything for maintainers to be made aware of

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please test it once and provide a video for demonstration. So far your changes in this PR are not reflected in UI since it is still taking 0.0.1.
  2. if Minio CDN Endpoint is provided, does it mean that Minio endpoint is no longer required?

@wingkwong wingkwong added the 🚧 Status: Changes Requested Some changes are needed to be made label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Status: Changes Requested Some changes are needed to be made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants