Skip to content

Commit

Permalink
fix: exclude sensitive data related to server from SMTP test api
Browse files Browse the repository at this point in the history
Signed-off-by: Pranav C <pranavxc@gmail.com>
  • Loading branch information
pranavxc committed Jun 13, 2022
1 parent a567f7a commit 2c1c2d1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/nocodb/src/lib/plugins/smtp/SMTP.ts
Expand Up @@ -47,7 +47,10 @@ export default class SMTP implements IEmailAdapter {
} as any);
return true;
} catch (e) {
throw e;
console.log('SMTP test error :: ', e);
throw new Error(
'SMTP test failed, please check server log for more details.'
);
}
}
}
Expand Down

2 comments on commit 2c1c2d1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR changes have been deployed. Pleae run the following command to verify:

docker run -d -p 8888:8080 nocodb/nocodb-timely:0.91.7-pr-2342-20220613-1029

@o1lab
Copy link
Member

@o1lab o1lab commented on 2c1c2d1 Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User data is supposed to be not sent - how does this solve it ? Am I missing something ?

Please sign in to comment.