Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Uses of rec #390

Merged
merged 2 commits into from Feb 21, 2024

Conversation

sivizius
Copy link
Contributor

@sivizius sivizius commented Feb 1, 2024

This PR removes unnecessary usage of rec. This is not about rec sometimes considered an anti-pattern, this is about code, where this keyword can simply be removed. Because linters like statix complain, they have to configured to ignore sources.nix, which is somewhat annoying. This PR should fix that.

Copy link
Owner

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@nmattia
Copy link
Owner

nmattia commented Feb 2, 2024

EDIT: done

There's a test failure because Niv keeps track of the hashes of the different sources.nix versions:

 sources.nix
    has latest version:                   FAIL
      src/Niv/Sources/Test.hs:13:
      expected: "26ed55356db7673935329210a4f8c4a5"
       but got: "a8751de841ac5e0a60f4c2db7e8bbade"

if you want to have a go at it you can add a V29 in src/Niv/Sources.hs with hash "a87...", otherwise I'll have a look this evening!

@sivizius
Copy link
Contributor Author

I do not understand the test failure or how this is related to my and your changes. Is there something I could do to finish this PR?

@nmattia
Copy link
Owner

nmattia commented Feb 21, 2024

It's unrelated. Thanks for the PR!

@nmattia nmattia merged commit 67b245a into nmattia:master Feb 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants