-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the default nixpkgs to a rolling release #369
Conversation
ed92f71
to
0e4ffa9
Compare
👍 for the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Makes a lot of sense
data/nixpkgs.json
Outdated
@@ -1,12 +1,12 @@ | |||
{ | |||
"branch": "release-21.05", | |||
"branch": "nixos-unstable-small", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between this, unstable & master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this wiki page is the best resource we have ATM https://nixos.wiki/wiki/Nix_channels#The_official_channels. Short but descriptive enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would default to a non -small
, since niv
seems to be used by a lot of beginners that might get surprised if they have to rebuild packages from source; also this is what we've done so far. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
The current default is release-21.05
, which is like master
, ahead of hydra and therefore have some uncached thing still. Instead of release-21.05
there would have been nixos-21.05
and nixos-21.05-small
, which are the versions after hydra advanced the channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right though I agree with the choise of "nixos-unstable" as a default since that's what most users I can think of would be looking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion about -small. Just wanted to point out the difference between branches that are before and those that are after hydra.
For security reasons niv should not initialize with a potentially outdated nixpkgs, that won't receive updates when even when the user calls `niv update`.
0e4ffa9
to
8020edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Sorry for the delay
why nixos- and not nixpkgs-unstable? |
good question CC @mweinelt ! |
The |
@mweinelt then I guess it makes sense to use |
It really depends on the user and what they care about. NixOS users will want to use the |
For security reasons niv should not initialize with a potentially
outdated nixpkgs, that won't receive updates when even when the user
calls
niv update
.Case in point: NixOS/nixpkgs#227804 (comment)