Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default nixpkgs to a rolling release #369

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

mweinelt
Copy link
Contributor

@mweinelt mweinelt commented Apr 23, 2023

For security reasons niv should not initialize with a potentially
outdated nixpkgs, that won't receive updates when even when the user
calls niv update.

Case in point: NixOS/nixpkgs#227804 (comment)

@turboMaCk
Copy link

👍 for the change

Copy link
Owner

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes a lot of sense

@@ -1,12 +1,12 @@
{
"branch": "release-21.05",
"branch": "nixos-unstable-small",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between this, unstable & master?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this wiki page is the best resource we have ATM https://nixos.wiki/wiki/Nix_channels#The_official_channels. Short but descriptive enough.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would default to a non -small, since niv seems to be used by a lot of beginners that might get surprised if they have to rebuild packages from source; also this is what we've done so far. Wdyt?

Copy link
Contributor Author

@mweinelt mweinelt Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

The current default is release-21.05, which is like master, ahead of hydra and therefore have some uncached thing still. Instead of release-21.05 there would have been nixos-21.05 and nixos-21.05-small, which are the versions after hydra advanced the channel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right though I agree with the choise of "nixos-unstable" as a default since that's what most users I can think of would be looking for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion about -small. Just wanted to point out the difference between branches that are before and those that are after hydra.

For security reasons niv should not initialize with a potentially
outdated nixpkgs, that won't receive updates when even when the user
calls `niv update`.
Copy link
Owner

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Sorry for the delay

@nmattia nmattia merged commit 7225521 into nmattia:master Apr 26, 2023
2 checks passed
@mweinelt mweinelt deleted the default-nixpkgs branch April 26, 2023 13:25
@gilice
Copy link

gilice commented Apr 26, 2023

why nixos- and not nixpkgs-unstable?

@nmattia
Copy link
Owner

nmattia commented Apr 27, 2023

good question CC @mweinelt !

@mweinelt
Copy link
Contributor Author

The nixos-* channels only cover aarch64- and x86_64-linux, but only gets bumped when the integration tests succeed, while nixpkgs-* only covers packages, but waits for darwin packages to build.

@nmattia
Copy link
Owner

nmattia commented Apr 27, 2023

@mweinelt then I guess it makes sense to use nixpkgs-*, right? We probably want a set of packages that works on Darwin; aside from that Niv doesn't really care about nixos but does about nixpkgs, wdyt?

@mweinelt
Copy link
Contributor Author

mweinelt commented Apr 27, 2023

It really depends on the user and what they care about. NixOS users will want to use the nixos-* channels for its tested guarantee. Darwin users should rely on nixpkgs-*, since the nixos-* branches advances without consideration for darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants