Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade automated code checks, part 2 #3219

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

purificant
Copy link
Member

This PR is a followup from #3217 to complete upgrade of automated code checks.

1 pyupgrade is set to py38+, this change has no effect on the codebase.
2 black is upgraded 22.3.0 -> 23.12.0
3 pre-commit run --all-files is executed against the codebase to apply the latest black formatting, this results in two types of changes: a) whitespace, line added / removed b) remove paranthesis in python tuple unpacking in the for loops.

Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stevenbird stevenbird merged commit bc32be0 into nltk:develop Dec 18, 2023
20 checks passed
@stevenbird
Copy link
Member

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants