fix: enable py 3.12 in ci and fix error in bleu calculation #3207
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4black
changed the title
|
@stevenbird @tomaarsen |
|
Thanks @k4black ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Fraction(..., _normalize=False)was removed in python 3.12 so it causes error in NLTK functions trying to call it this way.Changes
Enable CI testing for python 3.12
Indicate 3.12 in docs and metadata
Fix BLEU calculation
I have add Child class for Fraction to support
_normalize=False. Please let me know is better to have functions return(numerator, denominator)instead of complex class.