Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape sequences #2493

Closed
wants to merge 2 commits into from
Closed

Fix escape sequences #2493

wants to merge 2 commits into from

Conversation

ab-10
Copy link
Contributor

@ab-10 ab-10 commented Jan 30, 2020

Pull request in response to #2378

@stevenbird
Copy link
Member

Thanks @ab-10, this is a welcome contribution. Unfortunately it breaks a lot of the doctests. Would you like to have a look at the CI logs and see if you can work out what's going wrong?

@ab-10
Copy link
Contributor Author

ab-10 commented Mar 10, 2020

@stevenbird I think I took the wrong approach of rewriting all escape sequences without testing along the way. I will make a more responsible escape sequence fix when I have a little bit more time.

@stevenbird stevenbird closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ab-10 @stevenbird