Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate() for Text #2300

Merged
merged 5 commits into from
May 20, 2019
Merged

Add generate() for Text #2300

merged 5 commits into from
May 20, 2019

Conversation

alvations
Copy link
Contributor

C.f. #736 and #2251

The lidstone LM is a much slower than MLE so the generate() didn't try to replicate Lidstone with 0.2 gamma but uses the MLE model, 73f7e7b#diff-f5cb9102f911e93ca5fefa00b56a1e3f

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick! I have a lot of questions :)

nltk/text.py Outdated Show resolved Hide resolved
nltk/text.py Outdated Show resolved Hide resolved
nltk/text.py Outdated Show resolved Hide resolved
nltk/text.py Outdated Show resolved Hide resolved
nltk/text.py Outdated Show resolved Hide resolved
nltk/text.py Show resolved Hide resolved
nltk/text.py Show resolved Hide resolved
nltk/text.py Outdated Show resolved Hide resolved
@alvations
Copy link
Contributor Author

Thanks @copper-head for the review and all the helpful suggestions! I've committed the appropriate changes =)

@iliakur
Copy link
Contributor

iliakur commented May 17, 2019

Look at all the pesky whitespace and long lines that black deleted for us :)

Thanks for implementing the feedback, lgtm!

@alvations alvations added the LGTM label May 17, 2019
@stevenbird
Copy link
Member

Thanks @alvations and @copper-head... it's great to have this functionality back finally!

@stevenbird stevenbird merged commit c9a8f5e into nltk:develop May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants