-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate() for Text #2300
Add generate() for Text #2300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was quick! I have a lot of questions :)
Thanks @copper-head for the review and all the helpful suggestions! I've committed the appropriate changes =) |
Look at all the pesky whitespace and long lines that black deleted for us :) Thanks for implementing the feedback, lgtm! |
Thanks @alvations and @copper-head... it's great to have this functionality back finally! |
C.f. #736 and #2251
The lidstone LM is a much slower than MLE so the
generate()
didn't try to replicate Lidstone with 0.2 gamma but uses the MLE model, 73f7e7b#diff-f5cb9102f911e93ca5fefa00b56a1e3f