Add chomsky_normal_form for CFGs #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also in the Contribution Guidelines, it was written to follow Pep8, but while coding I observed pep8 is not followed uniformly, is there any subset of rules used from Pep8? O/w maybe we can enforce a Pep8 check via a linter? |
|
@virresh - thanks for the contribution; are you able to take a look in the nltk/test directory for examples of approaches to testing please? |
Added unittest for to_chomsky_normal_form()
|
Hello |
|
Thanks @virresh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1884
Am a bit unfamiliar with tox style of tests
Would be happy to add a CKY implementation and test the grammar converter as well if someone can guide me to the correct files for including tests and a parser