Issue #1859: TypeError in HiddenMarkovModelTrainer train_unsupervised #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…domProbDist and MutableProbDist
|
@PavanGJ would you please document the reason for this PR |
|
Hi @stevenbird This PR fixes a bug reported in #1859. RandomProbDist and MutableProbDist extend ProbDistI which defines an abstract method max. The abstract method is not overridden in RandomProbDist and MutableProbDist causing errors such as When a model is not defined, HiddenMarkovModelTagger uses both RandomProbDist and MutableProbDist in train_unsupervised method. This PR defines the method max in the two classes to overcome this bug. |
|
@stevenbird Kindly let me know if I need to document the reason for this PR elsewhere |
|
Excellent, thanks @PavanGJ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method definition for abstract method max in RandomProbDist and MutableProbDist classes.