Issues warning upon calling deprecated generate() function #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SaintNazaire Even if this code is self explanatory, I would suggest you to provide a description for your future pull requests, in order to make it easier to review them. (I think we could close some of those issues since they all refer to the same problem). Regarding the content of the PR: I would probably avoid specifying the NLTK version in the warning, or make it dynamic so that it refers the current NLTK version. We do not know if this will be fixed in the next release; if not, we would have to change the warning every time NLTK is updated and I think this is not desirable. |
fievelk
approved these changes
Nov 20, 2016
|
I'll merge this and fix the version issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.