refactor: limit the use of viper in packages outside cmd #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using viper outside command initialization and configuration makes it difficult to see what options gets applied. This commit refactors the initialization of the Filter struct in the filter package to use functional options over initializing from viper.
trym-b
reviewed
Feb 28, 2024
Comment on lines
+75
to
+80
| c.filter = filter.New( | ||
| filter.WithMimeType(viper.GetStringSlice(flag.MimeType)), | ||
| filter.WithResponseCode(viper.GetString(flag.ResponseCode)), | ||
| filter.WithRecordIds(viper.GetStringSlice(flag.RecordId)), | ||
| filter.WithRecordTypes(viper.GetStringSlice(flag.RecordType)), | ||
| ) |
There was a problem hiding this comment.
This code is identical to two other changes in this PR, could this be simplified further?
There was a problem hiding this comment.
Discussed it IRL: we'll improve this in a follow up PR
Comment on lines
+86
to
+91
| if i, e := strconv.Atoi(rc[0]); e == nil { | ||
| f.fromStatus = i | ||
| f.toStatus = i + 1 | ||
| } else { | ||
| panic(e) | ||
| } |
There was a problem hiding this comment.
I know this is outside of the scope of the PR, but this looks strange to me
Comment on lines
+57
to
+72
| case "warcinfo": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Warcinfo | ||
| case "request": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Request | ||
| case "response": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Response | ||
| case "metadata": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Metadata | ||
| case "revisit": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Revisit | ||
| case "resource": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Resource | ||
| case "continuation": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Continuation | ||
| case "conversion": | ||
| f.RecordTypes = f.RecordTypes | gowarc.Conversion |
There was a problem hiding this comment.
Also outside the scope of this PR, but I think we should use stronger types that does not require bit operations.
trym-b
approved these changes
Feb 29, 2024
|
@maeb I hope we can get this PR merged sometime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using viper outside command initialization and configuration makes it difficult to see what options gets applied.
This commit refactors the initialization of the Filter struct in the filter package to use functional options over initializing from viper.