feat: WARC record iterator #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned IRL yesterday, I think we should not merge this without also merging a use case at the same time (in the same PR). Otherwise, we are basically merging dead code. |
maeb
force-pushed
the
feat/warc-record-iterator
branch
from
3b95fb8
to
9e00cd7
Compare
maeb
force-pushed
the
feat/warc-record-iterator
branch
2 times, most recently
from
7364e80
to
857876f
Compare
maeb
force-pushed
the
feat/warc-record-iterator
branch
4 times, most recently
from
b943277
to
79a6fc2
Compare
maeb
force-pushed
the
feat/warc-record-iterator
branch
from
79a6fc2
to
e9271b8
Compare
The gowarc.WarcFileReader does not provide a simple way to get the size of the next WARC record. This commit introduces an iterator abstraction for iterating over WARC records. In addition to returning the size of each record the iterator encapsulates the filtering of records, limiting the number of records and selecting the nth record.
maeb
force-pushed
the
feat/warc-record-iterator
branch
from
e9271b8
to
12d5dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gowarc.WarcFileReader does not provide a simple way to get the size of the next record.
This PR introduces an iterator abstraction for iterating over WARC records. In addition to returning the size of each record the iterator encapsulates:
This PR only includes the implementation of the iterator. Future pull requests will start using it.edit: added use cases