fix: add error handling to workerPool
#108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrbo
approved these changes
Mar 22, 2024
|
From IRL review with @maeb. If the error channel gets filled, then we will end up with a deadlock. So we need to ensure that we also empty the error channel before merging this PR. We should probably have a better test data set before continuing with this task |
# Motivation The functions submitted to `workerPool` might fail, and the errors they return should be properly propagated. # Changes To propagate the errors to the main goroutine, a channel is used to transfer the errors. When closing the `workerPool` any errors transferred will be evaluated and if there is any none-nil errors, the first one will be returned. # Quirks This commit also disables the sub-linter `gocyclo` for a function in `filewalker.go` as it is the refactoring triggered by this commit increase the complexity. This complexity is only intermediate and will be removed upon further refactoring. The original linter error was the following: ``` lint: internal/filewalker/filewalker.go#L192 cyclomatic complexity 31 of func `(*fileWalker).Walk` is high (> 30) (gocyclo) ```
trym-b
force-pushed
the
fix/handle-file-walker-errors-part-2
branch
from
9cc9ac2
to
b185ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The functions submitted to
workerPoolmightfail, and the errors they return should be
properly propagated.
Changes
To propagate the errors to the main goroutine, a
channel is used to transfer the errors. When
closing the
workerPoolany errors transferredwill be evaluated and if there is any none-nil
errors, the first one will be returned.
Quirks
This commit also disables the sub-linter
gocyclofor a function infilewalker.goas it is therefactoring triggered by this commit increase the
complexity.
This complexity is only intermediate and will be
removed upon further refactoring.
The original linter error was the following: