Skip to content

Commit

Permalink
Made several entity attributes nullable to prevent parse exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
nkl-kst committed May 4, 2021
1 parent 0b1e00a commit dc82332
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 33 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.1] - 2021-05-04

### Fixed
- Made several entity attributes nullable to prevent parse exceptions

## [1.0.0] - 2021-05-02

### Added
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ $client->configure()->setKey('YOUR_API_KEY');
## Known issues

- Livescores for v1 are not supported.
- If you are getting an exception like `JSON property "foo" in class "Bar" must not be NULL`, then there is an entity
attribute which should be nullable. Please open a new issue in this case.

## Feedback

Expand Down
2 changes: 1 addition & 1 deletion src/Entity/Event/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Event
public ?int $idSoccerXML;
public ?int $idAPIfootball;
public string $strEvent;
public string $strEventAlternate;
public ?string $strEventAlternate;
public string $strFilename;
public string $strSport;
public int $idLeague;
Expand Down
2 changes: 1 addition & 1 deletion src/Entity/Event/Statistic.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Statistic
{
public int $idStatistic;
public int $idEvent;
public int $idApiFootball;
public ?int $idApiFootball;
public string $strEvent;
public string $strStat;
public int $intHome;
Expand Down
6 changes: 3 additions & 3 deletions src/Entity/Event/Timeline.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ class Timeline
public string $strTimelineDetail;
public string $strHome;
public string $strEvent;
public int $idAPIfootball;
public ?int $idAPIfootball;
public int $idPlayer;
public string $strPlayer;
public ?int $idAssist;
public string $strAssist;
public ?string $strAssist;
public int $intTime;
public int $idTeam;
public string $strTeam;
public string $strComment;
public ?string $strComment;
public DateTime $dateEvent;
public string $strSeason;
}
12 changes: 6 additions & 6 deletions src/Entity/League.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ class League
public ?DateTime $dateFirstEvent;
public string $strGender;
public string $strCountry;
public string $strWebsite;
public string $strFacebook;
public string $strTwitter;
public string $strYoutube;
public string $strRSS;
public ?string $strWebsite;
public ?string $strFacebook;
public ?string $strTwitter;
public ?string $strYoutube;
public ?string $strRSS;
public string $strDescriptionEN;
public ?string $strDescriptionDE;
public ?string $strDescriptionFR;
Expand All @@ -50,5 +50,5 @@ class League
public ?string $strTrophy;
public string $strNaming;
public ?string $strComplete;
public string $strLocked; // "unlocked"
public string $strLocked;
}
20 changes: 10 additions & 10 deletions src/Entity/Player/Player.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ class Player
public DateTime $dateBorn;
public ?string $strNumber;
public DateTime $dateSign;
public string $strSigning;
public string $strWage;
public ?string $strSigning;
public ?string $strWage;
public ?string $strOutfitter;
public ?string $strKit;
public ?string $strAgent;
public string $strBirthLocation;
public string $strDescriptionEN;
public ?string $strBirthLocation;
public ?string $strDescriptionEN;
public ?string $strDescriptionDE;
public ?string $strDescriptionFR;
public ?string $strDescriptionCN;
Expand All @@ -46,12 +46,12 @@ class Player
public ?string $strSide;
public string $strPosition;
public ?string $strCollege;
public string $strFacebook;
public string $strTwitter;
public string $strInstagram;
public string $strYoutube;
public string $strHeight;
public string $strWeight;
public ?string $strFacebook;
public ?string $strTwitter;
public ?string $strInstagram;
public ?string $strYoutube;
public ?string $strHeight;
public ?string $strWeight;
public int $intLoved;
public ?string $strThumb;
public ?string $strCutout;
Expand Down
24 changes: 12 additions & 12 deletions src/Entity/Team.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ class Team
public ?int $intLoved;
public string $strTeam;
public ?string $strTeamShort;
public string $strAlternate;
public int $intFormedYear;
public ?string $strAlternate;
public ?int $intFormedYear;
public string $strSport;
public string $strLeague;
public int $idLeague;
Expand All @@ -28,18 +28,18 @@ class Team
public ?string $strLeague7;
public ?int $idLeague7;
public ?string $strDivision;
public string $strManager;
public string $strStadium;
public ?string $strManager;
public ?string $strStadium;
public ?string $strKeywords;
public string $strRSS;
public ?string $strRSS;
public ?string $strStadiumThumb;
public ?string $strStadiumDescription;
public string $strStadiumLocation;
public int $intStadiumCapacity;
public string $strWebsite;
public string $strFacebook;
public string $strTwitter;
public string $strInstagram;
public ?string $strStadiumLocation;
public ?int $intStadiumCapacity;
public ?string $strWebsite;
public ?string $strFacebook;
public ?string $strTwitter;
public ?string $strInstagram;
public ?string $strDescriptionEN;
public ?string $strDescriptionDE;
public ?string $strDescriptionFR;
Expand All @@ -65,6 +65,6 @@ class Team
public ?string $strTeamFanart3;
public ?string $strTeamFanart4;
public ?string $strTeamBanner;
public string $strYoutube;
public ?string $strYoutube;
public string $strLocked;
}

0 comments on commit dc82332

Please sign in to comment.