Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client support for self signed certificate on MQTT server #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sjd-Risca
Copy link

I'd like to use the mqtt client against a server with a self signed Certificate Authority. The proposed patch will add a new client configuration attribute defined as ca_certs for assigning a custom CA (instead of using the system ones) to the ssl context. The connection will be initiated only if the mqtt server's certificate chain resolved to any of the custom CAs.

For reference, see the implementation from patho-mqtt: https://github.com/eclipse/paho.mqtt.python/blob/225ab3757f6818ba85eb80564948d1c787190cba/src/paho/mqtt/client.py#L767

@HerrMuellerluedenscheid

Nice! Can you think of a unit test for this feature? Maybe creating a tempfile and a certificate and loading that? I mean your changes use external logic, thus nothing should go wrong here. But it comes very handy when adding functionality.

@FlorianLudwig
Copy link
Contributor

Hi @Sjd-Risca

hbmqtt has been deprecated by it's author. We created a fork here: https://github.com/Yakifo/amqtt

I like this change and would like to include it in our fork.

Would you be interested to create your MR there as well?

Thanks :)

@FlorianLudwig
Copy link
Contributor

@HerrMuellerluedenscheid would you be interested in carrying this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants