Avoid to close @socket of MQTT::Client unexpectedly #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a revised patch of #129. |
|
The patch can be simplified by using |
ashie
force-pushed
the
client-socket-lock
branch
2 times, most recently
from
c8750be
to
5e3356d
Compare
Since it is locked only when writing, it may be closed by anothre thread while reading or writing. In actual we often get the following error when we are processing massive messages by fluent-plugin-mqtt-io: IOError,stream closed in another thread This commit ensure to protect all atomic operations of the socket. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Although an error should be always raised on exiting @read_thread to break `get` loop, there was a case that it's not raised. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
client-socket-lock
branch
from
5e3356d
to
683ce8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is locked only when writing, it may be closed by anothre thread
while reading or writing. In actual we often get the following error
when we are processing massive messages by fluent-plugin-mqtt-io:
IOError,stream closed in another thread
This commit ensure to protect all atomic operations of the socket.