Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statemodel update refresh #262

Open
wants to merge 10 commits into
base: sane-default-is_list_index
Choose a base branch
from

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Dec 31, 2021

Rework DynamicListOf and DynamicAttrsOf so it follows an update-StateModel -> refresh navlist procedure to isolate the source of state to one place. This applies to all operations.

  • StateModel mutation -> refresh(): DynamicListOf.remove_clicked
  • StateModel mutation -> refresh(): DynamicListOf.add_clicked
  • StateModel mutation -> refresh(): DynamicAttrsOf.rename_item
  • StateModel mutation -> refresh(): DynamicAttrsOf.add_clicked
  • StateModel mutation -> refresh(): DynamicAttrsOf.remove_clicked

Misc Cleanup:

  • remove dead code: editing and renaming functionality in DynamicListOf
  • ensure DynamicListOf.add_item adds a list index, not newAttribute
  • sorting of lists is wrong, [10] is comes before [0] because string sort is used
  • Don't edit DynamicAttrsOf on double click, edit on f2 with edit button

Smoke Test Checks:

Further PRs (before v0.2 release):

  • Apply max_renderable_field_widgets so the universe of fields aren't rendered.

@lapp0 lapp0 changed the base branch from master to sane-default-is_list_index December 31, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant