Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
DynamicListOf
andDynamicAttrsOf
so it follows an update-StateModel -> refresh navlist procedure to isolate the source of state to one place. This applies to all operations.StateModel
mutation ->refresh()
:DynamicListOf.remove_clicked
StateModel
mutation ->refresh()
:DynamicListOf.add_clicked
StateModel
mutation ->refresh()
:DynamicAttrsOf.rename_item
StateModel
mutation ->refresh()
:DynamicAttrsOf.add_clicked
StateModel
mutation ->refresh()
:DynamicAttrsOf.remove_clicked
Misc Cleanup:
DynamicListOf
DynamicListOf.add_item
adds a list index, notnewAttribute
[10]
is comes before[0]
because string sort is usedDynamicAttrsOf
on double click, editon f2with edit buttonSmoke Test Checks:
DynamicListOf
add- [ ]DynamicListOf
remove- [ ] doesn't decrement the index of elements following, fixDynamicListOf
upDynamicListOf
downDynamicAttrsOf
addDynamicAttrsOf
renameDynamicAttrsOf
removeFurther PRs (before v0.2 release):
max_renderable_field_widgets
so the universe of fields aren't rendered.