Fix dynamic selection #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 29, 2021 04:23
lapp0
commented
Dec 31, 2021
| itemWasSingleClicked = QtCore.pyqtSignal() | ||
| itemWasDoubleClicked = QtCore.pyqtSignal() | ||
|
|
||
| DOUBLE_CLICK_TIMEOUT = 200 # ms |
lapp0
commented
Dec 31, 2021
| @@ -351,6 +351,9 @@ def child_type(self): | |||
| else: | |||
| raise TypeError("Attempted to get child types, but no Either.subtypes allow children.", self) | |||
|
|
|||
| def get_child_type(self, type_cls): | |||
lapp0
commented
Dec 31, 2021
| @@ -45,7 +45,8 @@ def rename_option(self, old_option, option): | |||
| self._record_update(update) | |||
|
|
|||
| def swap_options(self, option0, option1): | |||
| placeholder = str(uuid.uuid4()) | |||
| # TODO: fix this hack, only using <name> because it isn't shown in OptionTree.children | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting an item in a
DynamicAttrsOforDynamicListOfchanges the navlist to aStaticAttrsOf. This is incorrect behavior, the selected attributes type shouldn't be considered when determining the navlist class, the attribute containing the navlist should determine the navlist class.Single/Double click: fixes #173
Dynamic Navlist Mutation
swap_optionsandrefreshare called forDynamicListOf.up_clickedanddown_clicked.OptionTree.rename_attributeBugs:
EitherType(OneOfType())is broken because theFieldWidgetcannot findEitherType.choices. Ensure choices can be discovered.insert_itemsdead code needs to be removedDocumentation
architecture.orgFurther PRs (before v0.2 release):
DynamicListOfandDynamicAttrsOfso it follows an update-StateModel -> refresh navlist procedure to isolate the source of state to one place. This applies to all operations.max_renderable_field_widgetsso the universe of fields aren't rendered.