Pass SSH private key using env var #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides the private key in the Terraform output. I'm not sure if this is enough to make the entire output public, but it's a step.
scottbot95
reviewed
Apr 13, 2023
| "switch", | ||
| var.delete_older_than, | ||
| ], | ||
| local.extra_build_args | ||
| ) | ||
| command = "ignoreme" | ||
| environment = { | ||
| BUILD_ON_TARGET = local.build_on_target |
There was a problem hiding this comment.
Making the ssh_private_key a environmnet variable makes sense to me to avoid sensitive data in the output, but why is build_on_target also being moved to an env var? I don't think there's necessary any reason it shouldn't be an env var, but I also see no reason to move it.
| "switch", | ||
| var.delete_older_than, | ||
| ], | ||
| local.extra_build_args | ||
| ) | ||
| command = "ignoreme" | ||
| environment = { | ||
| BUILD_ON_TARGET = local.build_on_target | ||
| SSH_PRIVATE_KEY = local.ssh_private_key == "" ? "-" : local.ssh_private_key |
There was a problem hiding this comment.
While this will hide the key itself from output, a variable still marked as sensitive will cause the output to be suppressed. Might be worth wrapping this in nonsensitive() although that would require bumping the minimum required terraform version from 0.12 to 0.15. Also there should be nothing stopping callers from wrapping the key in nonsensitive() when they pass it to this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the private key in the Terraform output. I'm not sure if this is enough to make the entire output public, but it's a step.