Poetry2nixify nixops_gcp + Python3 migration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and using it to retrieve images from publicly available image families. Extracting the public image from the target project first then create a volume out of that image [ No need to copy it in every deployment]
…condition on fileSystemsOptions
Removal of itertems and replacing it with items/values Removal of 'filter' and replacing it with list comprehension Updating relative imports
|
@tewfik-ghariani Great 🎉 , thanks. Quick comments:
|
tewfik-ghariani
force-pushed
the
poetry2nixify
branch
from
22b22cb
to
4f5e3da
Compare
… into poetry2nixify
This reverts commit b7fbd63.
|
@AmineChikhaoui adding mypy type annotations seems to be a manual and lengthy process. Can we review and merge this PR and after that include mypy? That way even others may contribute and help cover all functions/variables and it least we would have the nixops-gce plugin working using poetry |
adisbladis
approved these changes
May 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing the broken bootstrap resource per #1 and making the plugin work again, I wanted to work on upgrading the python version used as the main nixops is already using python3
And then I stumbled upon the new initiative to move to Poetry as dependency manager so here I am, bringing nixops_gcp up to speed 😃
This PR includes :
Followed the authoring guidelines shared per: https://github.com/NixOS/nixops/blob/master/doc/plugins/authoring.rst
Tested all sort of actions and everything seems to be working fine. The only problem I faced in the "check" operation as it fails saying that it cannot operate on a 'closed database'
Not sure if this is a 'dev-shell' limitation or if I'm missing something
EDIT The check operation has been fixed per NixOS/nixops#1334
Thanks @adisbladis for leading the initiative and @grahamc for your hard work
cc @AmineChikhaoui can you review and merge this please :)