remove use of meta = with lib;
#292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@figsoda any feedback on this? |
eclairevoyant
force-pushed
the
remove-with-lib
branch
from
677db11
to
3e5d674
Compare
Open
|
Sorry that I forgot about this for so long. Is there a consensus on this? If not maybe I can create a poll or something like that |
|
In my experience it gets constantly nitpicked in nixpkgs, |
|
No, there is no consensus on removing it from |
eclairevoyant
changed the title
with lib; (see NixOS/nixpkgs#208242)with lib;
This comment was marked as outdated.
This comment was marked as outdated.
eclairevoyant
changed the title
with lib;meta = with lib;
|
NB as mentioned in NixOS/nixpkgs#292468 (comment), (TLDR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivating discussion: NixOS/nixpkgs#208242
Additional context: NixOS/nixpkgs#292468, NixOS/nixpkgs#293767
Fixes #414.