Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Windows Hello Authentication #83

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Apr 21, 2022

This adds an option to approve sudo and other login prompts through Windows Hello (Fingerprint/Face/PIN/etc.) instead of a password or not at all (as is the default)

@nzbr nzbr added the enhancement New feature or request label Apr 21, 2022
@nzbr
Copy link
Member Author

nzbr commented Apr 25, 2022

This seems to stop working sometimes (exit code 255 from the .exe). That can be fixed by opening a new shell - it's probably related to the WSL_INTEROP socket

Comment on lines +27 to +42
authenticator = pkgs.stdenv.mkDerivation {
name = "WindowsHelloAuthenticator.exe";
src = pkgs.fetchurl {
url = "https://github.com/nzbr/PAM-WindowsHello/releases/download/v1/WindowsHelloAuthenticator.exe";
sha256 = "4856a1fefa5c869b78890f9313a560d310e9c11f2a2a212c2868cf292792ff7f";
};
dontUnpack = true;
buildCommand = ''
install -m 0755 $src $out
'';
};
wrapper = pkgs.writeShellScript "wrapper" ''
export PATH=${pkgs.coreutils}/bin # The PAM environment does not include the default PATH
export WSL_INTEROP="/run/WSL/$(ls -tr /run/WSL | tail -n1)" # Find the correct WSL_INTEROP socket to be able to start the EXE
exec ${authenticator} [$PAM_SERVICE] $PAM_RUSER wants to authenticate as $PAM_USER
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make a proper package out of that. Could we build it from source, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it'd be possible to build from source. The program has build-time dependencies against Windows.winmd and System.Runtime.WindowsRuntime.dll
If there's any way to get those files into the nix store, it might be possible to build with Mono though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect that, thanks! I'll look into it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it now (the correct package is https://www.nuget.org/packages/Microsoft.Windows.SDK.Contracts btw. The one above seems to be for parsing WinMD files), however I could not get msbuild on Linux to compile the executable. It always threw an error about a missing assembly reference. I also tried porting the helper to .NET 6, but that wouldn't build on Linux either because NETSDK1100: Windows is required to build Windows desktop applications. I had initially meant to build it in .NET 6, but couldn't figure out how to import WinRT then. In retrospect that was fortunate, because now I learned that .NET 6 would require having an additional .dll in the same directory as the .exe, whereas .NET Framework only requires the .exe to be present

TL;DR Unfortunately it looks like there is no way to build the helper on linux

@nzbr nzbr changed the title Windows Hello Authentication WIP: Windows Hello Authentication Jun 29, 2022
@nzbr nzbr marked this pull request as draft July 19, 2022 18:04
@aikooo7
Copy link

aikooo7 commented Feb 11, 2024

What needs to be done to this be merged?

@nzbr
Copy link
Member Author

nzbr commented Feb 12, 2024

The Nix code in this PR is pretty outdated and would probably need to be adjusted to the current state of the main branch. Also the windows binary this uses can't be cross-compiled on linux and therefore needs to be pulled in as a binary blob. If that's possible the windows part should be rewritten in something like rust where that's possible, so that it can be built in a derivation

@Cu3PO42
Copy link

Cu3PO42 commented Mar 17, 2024

I actually did a rewrite of both the PAM module and the Windows side (in Rust) for this roughly two years ago. It also doesn't use any unsupported APIs anymore and should cross-compile. It worked, but I have a feeling it wasn't fully done. It's currently rotting in a private repo, but I'll see about cleaning it up.

@nzbr
Copy link
Member Author

nzbr commented Mar 17, 2024

That'd be really cool, tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants