Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - use %localappdata% instead of the cwd #438

Merged
merged 3 commits into from Mar 15, 2024

Conversation

noamraph
Copy link
Contributor

Hi,

I first installed NixOS-WSL according to the instructions in the README.md, and it created a NixOS folder in my Downloads folder, in which the filesystem was stored. I saw that the other WSL filesystems are located in %localappdata% (AppData\Local), so this seems like a much better instruction to give in the README file.

Also, the README include adding --version 2. It works, but I don't think it does anything. wsl --help shows that --version just displays the version. I checked, and the command works without the --version 2 arguments just as well.

@SuperSandro2000
Copy link
Member

I saw that the other WSL filesystems are located in %localappdata% (AppData\Local), so this seems like a much better instruction to give in the README file.

That's because they are installed through the store and managed by the respective apps. Since we want to add that eventually, too, we should not occupy that directory. So far I always placed it under my user directory.

@noamraph
Copy link
Contributor Author

@SuperSandro2000 I agree, the user directory seems like a better place. So, I changed the PR to use %userprofile% instead of %localappdata%.

@nzbr
Copy link
Member

nzbr commented Mar 12, 2024

For consistency, please change that in docs/src/install.md as well

@noamraph
Copy link
Contributor Author

@nzbr thanks, I didn't know about that file. Done!

@nzbr nzbr added the documentation Improvements or additions to documentation label Mar 12, 2024
@nzbr nzbr merged commit d42bd4e into nix-community:main Mar 15, 2024
25 checks passed
@nzbr
Copy link
Member

nzbr commented Mar 15, 2024

FYI: I changed the primary install command to PowerShell, because that's the default shell on Windows now. The detailed instructions now have both commands

@noamraph
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants