Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDEV-18561: Incorrect Remediation Diff #127

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

harshitraj2002
Copy link
Contributor

@harshitraj2002 harshitraj2002 commented Mar 19, 2024

Ticket

Jira

Description

Fixed the remediation diff contains ordering changes in remediate-disallow-capabilities-strict.yaml.
Used patchesJson6902 instead of patchStrategicMerge.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested it on a test-resource.yaml and got the required result.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pns-nirmata pns-nirmata merged commit 6a31e66 into main Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants