Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cases n4k with venafi for image verification #46

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anubhav888
Copy link

No description provided.

Copy link

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also too many excess lines. Standardize on a single new line in Markdown. This will be rendered appropriately in HTML.

Comment on lines +19 to +22
ghcr.io/nirmata/kyverno:v1.8.1-n4kbuild.1
ghcr.io/nirmata/kyvernopre:v1.8.1-n4kbuild.1
ghcr.io/nirmata/kube-rbac-proxy:v0.13.1
ghcr.io/nirmata/nirmata-imagekey-controller:v0.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to specify which exact tags to use in these instructions? When we upgrade, we'll have to come back and maintain this list.

Please use the below credentials provided to you to access N4K images -

Username: nirmata-enterprise-for-kyverno
Password: xx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something else other than "xx" here. Do they know where/how they'll obtain the password? Maybe put that as a sentence.

## Kyverno Installation


Install the Helm charts by following the instructions [here](https://github.com/nirmata/kyverno-charts/tree/main/charts/nirmata#installing-the-chart). The necessary credentials for the image repo must be passed during installation of the Helm repo to authenticate with the customer’s container registry. Set the image registry using the parameters below

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...during installation of the Helm chart..."

Install the Helm charts by following the instructions [here](https://github.com/nirmata/kyverno-charts/tree/main/charts/nirmata#installing-the-chart). The necessary credentials for the image repo must be passed during installation of the Helm repo to authenticate with the customer’s container registry. Set the image registry using the parameters below
```
--set image.repository=<registry_name>>
--set image.pullSecrets.registry=<<registry_name>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one set of angle brackets.

```


For custom certs, follow the custom cert section in the [installation](https://github.com/nirmata/kyverno-charts/tree/main/charts/venafi-adapter#installation) guide and use the parameters below to set the right ca bundle path and configmap.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Certificates"
"CA" (acronyms are capitalized)

For custom certs, follow the custom cert section in the [installation](https://github.com/nirmata/kyverno-charts/tree/main/charts/venafi-adapter#installation) guide and use the parameters below to set the right ca bundle path and configmap.
```
--set systemCertPath=/etc/pki/tls/certs
--set customCAConfigMap=<<configmap_name>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One set of angled brackets.

## Nirmata Venafi Adapter installation


Install the Helm charts by following the instructions [here](https://github.com/nirmata/kyverno-charts/tree/main/charts/venafi-adapter). The necessary credentials for the image repo must be passed during installation of the Helm repo to authenticate with the customer’s container registry. Set the image registry using the parameters below

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credentials are for the image registry.

"Helm chart"

Comment on lines +57 to +60
--set venafiAdapterImage=<<nirmata-imagekey-controller_image_full_path>>
--set imagePullSecret.registry=<<registry_name>>
--set imagePullSecret.username=<<user>>
--set imagePullSecret.password=<<password>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angle brackets comment again.

```


For custom certs, follow the custom cert section in the [installation](https://github.com/nirmata/kyverno-charts/tree/main/charts/venafi-adapter#installation) guide and use the parameters below to set the right ca bundle path and configmap.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Certificates"
"CA"


```
--set systemCertPath=/etc/pki/tls/certs
--set customCAConfigMap=<<configmap_name>>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants