ENH: Outsource apply() from transform objects
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
reviewed
May 16, 2024
| else None | ||
| ) | ||
|
|
||
| for t, xfm_t in enumerate(self): |
There was a problem hiding this comment.
I've been holding on this one - the new implementation is 4D, while the old implementation was 3D+t (meaning that you could not resample off-gried on the fourth dimension).
We should make sure we meet today @effigies, @jmarabotto and discuss this.
cc/ @sgiavasis who may be interested in learning more.
oesteban
changed the title
apply() from transform objects
oesteban
reviewed
May 16, 2024
outsourced Apply(); fixed resampled.py (line 101); implemented np.tensordor to _apply_affine() in main.py (line 287). Left to do: fix test_linear RunTime error (line 358)
Outsourced apply, test_linear.py successful
Apply function offsourced. Tests: 139 passed, 163 Skipped, 15 Warnings
effigies
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have joined CHUV (Lausanne, Switzerland) for a 5 month placement and am working with Oscar Esteban on this project. We worked through this problem together as an example of how I can contribute and resolve issues, as I am somewhat new to GitHub. Eventually, this Resolves #192 - but for now, this acts as an example and further changes are needed :)