Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add test for the CLI parser #1293

Merged
merged 1 commit into from May 20, 2024

Conversation

jhlegarreta
Copy link
Contributor

Add test for the CLI parser.

@jhlegarreta
Copy link
Contributor Author

Leaving the groups for a separate PR:
https://github.com/nipreps/mriqc/blob/master/mriqc/cli/parser.py#L166

@oesteban
Copy link
Member

Very much needed -- thanks for initiating this. Let me know how I can help.

@jhlegarreta
Copy link
Contributor Author

Very much needed -- thanks for initiating this. Let me know how I can help.

Thanks Óscar. The CircleCI test errors seem unrelated:
https://app.circleci.com/pipelines/github/nipreps/mriqc/1353/workflows/ae93f4b7-94c6-492c-9204-455abfcdd103/jobs/8173?invite=true#step-103-264_18
https://app.circleci.com/pipelines/github/nipreps/mriqc/1353/workflows/ae93f4b7-94c6-492c-9204-455abfcdd103/jobs/8174?invite=true#step-103-263_18

I think I had tried locally with success.

But is there a mechanism in place to fetch some testing data from Python? I see that a step in CircleCI retrieves some data from a URL

mriqc/tests/test_parser.py Outdated Show resolved Hide resolved
mriqc/tests/test_parser.py Outdated Show resolved Hide resolved
mriqc/tests/test_parser.py Outdated Show resolved Hide resolved
mriqc/tests/test_parser.py Outdated Show resolved Hide resolved
@jhlegarreta
Copy link
Contributor Author

Thanks for the review and suggestions Óscar.

Created a helper _create_set_bids_dir as the pattern was being repeated.

Squashed commits.

Push forced. Not sure about the verbosity one. Will see in the CI.

Add test for the CLI parser.
@oesteban oesteban merged commit 29fe9b9 into nipreps:master May 20, 2024
15 checks passed
Copy link

welcome bot commented May 20, 2024

Thanks for opening this pull request and congratulations for taking it to the finish line! It looks like this is your first time contributing to MRIQC. 😄
We invite you to list yourself as an MRIQC contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order of (i) lastname and (ii) firstname, into the .maint/CONTRIBUTORS.md file.
Of course, if you want to opt-out this time, there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

@jhlegarreta jhlegarreta deleted the AddCLIParserTest branch May 20, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants