Fixed #401 and #431 : address issues with addon list and quantity validation

[rahil1202]

What this PR does ?

Fixed #401 and #431

• Initialize the addon state as an empty array when there is no initial addon data
• Update the validation logic for quantityMinimum and quantityMaximum to mark values of zero as errors

The addon list will now be empty initially when there is no pre-existing addon data.
Additionally, the quantityMinimum and quantityMaximum fields will not accept a value of zero and will only allow positive integers greater than zero.

Summary by CodeRabbit

• Bug Fixes
  • Improved error checking and initialization in the addon management component, ensuring better handling of quantity limits.

[coderabbitai]

Walkthrough

The recent update in the Addon.jsx file primarily focuses on refining the validation logic for addon quantities in a restaurant management system. The changes ensure that negative values are not accepted for addon quantities and that errors are properly flagged for values that do not meet the specified criteria.

Changes

File Path	Change Summary
.../Addon/Addon.jsx	Modified array initialization, adjusted error checks for min and max quantity values, added zero value check.

Assessment against linked issues

Objective	Addressed	Explanation
Add on showing error for value greater than 0 (#401)	✅

Poem

🐰 Oh hop and cheer, for changes are here,
No more negatives, that's crystal clear.
🌟 From min to max, we check with care,
Each addon value, fair and square.
In code we trust, to make things right,
Bugs hop away, out of sight! 🚀

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 30d17e3 and 6bd346d.

Files selected for processing (1)

• enatega-multivendor-admin/src/components/Addon/Addon.jsx (3 hunks)

Additional comments not posted (2)

enatega-multivendor-admin/src/components/Addon/Addon.jsx (2)

79-79: Initialization of the addon list as an empty array when no initial data is present is correctly implemented.

---

115-116: The modified validation logic for quantityMinimum and quantityMaximum correctly handles zero values as invalid inputs. Ensure to test these changes across various scenarios to confirm their robustness.

Also applies to: 127-128

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for polite-fairy-234917 ready!

Name	Link
🔨 Latest commit	6bd346d
🔍 Latest deploy log	https://app.netlify.com/sites/polite-fairy-234917/deploys/66260f21a0c5ad000871aacd
😎 Deploy Preview	https://deploy-preview-480--polite-fairy-234917.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for cheery-zabaione-34f12e ready!

Name	Link
🔨 Latest commit	6bd346d
🔍 Latest deploy log	https://app.netlify.com/sites/cheery-zabaione-34f12e/deploys/66260f21927e8700088c7a76
😎 Deploy Preview	https://deploy-preview-480--cheery-zabaione-34f12e.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[usama-sattar]

The zero check is not linked with issue where minimum value showing error, although it is less than maximum. The error must be due to the fact that state is not updating. Please check and let me know if there is any confusion.