Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MAVEN build Performance #718

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve MAVEN build Performance #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
70 changes: 8 additions & 62 deletions ninja-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,7 @@
<artifactId>guice</artifactId>
</dependency>

<dependency>
<groupId>com.google.inject.extensions</groupId>
<artifactId>guice-assistedinject</artifactId>
</dependency>

<!-- We use Jackson for rendering jsons: -->

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
Expand Down Expand Up @@ -136,18 +131,8 @@
</dependency>

<!-- Replace commons-logging with slf4j bridge (that will use logback)-->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
</dependency>

<!-- Replace log4j with slf4j bridge (that will use logback)-->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>log4j-over-slf4j</artifactId>
</dependency>

<!-- Some nice stuff for handling IO. Some overlap with guava though... -->

<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand All @@ -173,25 +158,14 @@

<!-- Bean validation and reference implementation for JSR 303 -->
<!-- IMPORTANT: still using 4.3.1.Final because 5.0.1.Final NOT compatible with GAE -->
<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-validator</artifactId>
</dependency>

<!-- XML parsing -->

<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-xml</artifactId>
</dependency>

<!-- jackson-dataformat-xml prefers Woodstox as Stax impl -->
<dependency>
<groupId>com.fasterxml.woodstox</groupId>
<artifactId>woodstox-core</artifactId>
</dependency>

<!-- ehcache implementation -->
<!-- IMPORTANT: only pull in core (~1MB) vs. entire distro which includes a server (~7MB) -->
<dependency>
<groupId>net.sf.ehcache</groupId>
<artifactId>ehcache-core</artifactId>
Expand All @@ -204,28 +178,12 @@
</dependency>

<!-- Migration framework -->
<dependency>
<groupId>org.flywaydb</groupId>
<artifactId>flyway-core</artifactId>
</dependency>

<!-- JPA dependencies -->
<dependency>
<groupId>com.google.inject.extensions</groupId>
<artifactId>guice-persist</artifactId>
</dependency>



<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-entitymanager</artifactId>
</dependency>

<dependency>
<groupId>org.hibernate</groupId>
<artifactId>hibernate-c3p0</artifactId>
</dependency>

<!-- Testing -->

<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>java-hamcrest</artifactId>
Expand All @@ -246,22 +204,10 @@
<artifactId>mockito-core</artifactId>
</dependency>

<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-module-junit4</artifactId>
</dependency>

<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-api-mockito2</artifactId>
</dependency>

<!-- Jaxb was removed from Java 9 and onwards. So we add the dependency explicitly -->
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>2.3.0</version>
</dependency>



</dependencies>

Expand Down
6 changes: 1 addition & 5 deletions ninja-jaxy-routes/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@
<artifactId>reflections</artifactId>
</dependency>

<dependency>
<groupId>org.ninjaframework</groupId>
<artifactId>ninja-test-utilities</artifactId>
<scope>test</scope>
</dependency>


</dependencies>

Expand Down
7 changes: 1 addition & 6 deletions ninja-maven-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,7 @@
<version>3.1.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-compat</artifactId>
<version>3.1.0</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
Expand Down
10 changes: 2 additions & 8 deletions ninja-metrics-ganglia/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,9 @@ and limitations under the License. -->
</dependency>

<!-- Testing -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>


<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>

</dependencies>

</project>
10 changes: 2 additions & 8 deletions ninja-metrics-influxdb/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,9 @@ and limitations under the License. -->
</dependency>

<!-- Testing -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>


<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>

</dependencies>

</project>
10 changes: 2 additions & 8 deletions ninja-metrics-librato/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,9 @@ and limitations under the License. -->
</dependency>

<!-- Testing -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>


<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>

</dependencies>

</project>
5 changes: 1 addition & 4 deletions ninja-postoffice/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,7 @@
<artifactId>junit</artifactId>
</dependency>

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>


<dependency>
<groupId>com.icegreen</groupId>
Expand Down
2 changes: 1 addition & 1 deletion ninja-servlet-integration-test/build-run-jetty.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

mvn package -DskipTests=true
mvn -T 1C package -DskipTests=true
docker build -f Dockerfile.jetty --tag=ninja-jetty .
docker run -it -p 8080:8080 ninja-jetty
2 changes: 1 addition & 1 deletion ninja-servlet-integration-test/build-run-tomcat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

mvn clean package -DskipTests=true
mvn -T 1C clean package -DskipTests=true
docker build -f Dockerfile.tomcat --tag=ninja-tomcat2 .
docker run -it -p 8080:8080 ninja-tomcat2
2 changes: 1 addition & 1 deletion ninja-servlet-integration-test/build-run-wildfly.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

mvn package -DskipTests=true
mvn -T 1C package -DskipTests=true
docker build -f Dockerfile.wildfly --tag=ninja-wildfly .
docker run -it -p 8080:8080 ninja-wildfly
10 changes: 2 additions & 8 deletions ninja-servlet-integration-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,9 @@

<!-- for web ui only -->

<dependency>
<groupId>org.webjars</groupId>
<artifactId>bootstrap</artifactId>
</dependency>

<dependency>
<groupId>org.mindrot</groupId>
<artifactId>jbcrypt</artifactId>
</dependency>



<dependency>
<groupId>org.ninjaframework</groupId>
Expand Down
20 changes: 4 additions & 16 deletions ninja-servlet-jpa-blog-integration-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,25 +158,13 @@

<dependencies>

<dependency>
<groupId>org.webjars</groupId>
<artifactId>tinymce-jquery</artifactId>
</dependency>


<dependency>
<groupId>org.webjars</groupId>
<artifactId>bootstrap</artifactId>
</dependency>


<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
</dependency>


<dependency>
<groupId>org.ninjaframework</groupId>
<artifactId>ninja-servlet</artifactId>
</dependency>


<dependency>
<groupId>org.ninjaframework</groupId>
Expand Down
5 changes: 1 addition & 4 deletions ninja-standalone/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,7 @@
<scope>compile</scope>
</dependency>

<dependency>
<groupId>javax.websocket</groupId>
<artifactId>javax.websocket-api</artifactId>
</dependency>


<dependency>
<groupId>junit</groupId>
Expand Down
32 changes: 4 additions & 28 deletions ninja-test-utilities/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@
<scope>compile</scope>
</dependency>

<dependency>
<groupId>org.ninjaframework</groupId>
<artifactId>ninja-standalone</artifactId>
<scope>compile</scope>
</dependency>


<dependency>
<groupId>org.ninjaframework</groupId>
Expand All @@ -55,11 +51,7 @@

<!-- Testing is mainly done by mockito: -->
<!-- Order of hamcrest first then junit is important -->
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>java-hamcrest</artifactId>
<scope>compile</scope>
</dependency>


<dependency>
<groupId>org.assertj</groupId>
Expand All @@ -84,25 +76,9 @@
<artifactId>fluentlenium-junit</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>htmlunit-driver</artifactId>
<scope>compile</scope>
</dependency>
<!-- selenium uses jetty-client and has a version conflict with ours.
We must declare these to force the version to ours or websockets will break -->
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-client</artifactId>
<version>${jetty.version}</version>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.websocket</groupId>
<artifactId>websocket-client</artifactId>
<version>${jetty.version}</version>
</dependency>

<!--HttpCient is used to mainly test low level Json Apis -->


<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
Expand Down