Add set_resp_headers_list #1634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeksilva97
force-pushed
the
issue-1295
branch
2 times, most recently
from
d45c76e
to
29aedff
Compare
geeksilva97
commented
Apr 19, 2024
| @@ -366,6 +367,30 @@ uri2_test() -> | |||
| <<"http://localhost/path?dummy=2785">> = iolist_to_binary(uri(Req, #{port => 80})), | |||
| <<"https://localhost/path?dummy=2785">> = iolist_to_binary(uri(Req, #{scheme => "https", port => 443})), | |||
| ok. | |||
|
|
|||
| resp_headers_test() -> | |||
There was a problem hiding this comment.
If not needed we can remove this unit test. I was using it to validate the function behavior.
geeksilva97
commented
Apr 19, 2024
| set_resp_headers_list([], Map, Req) -> | ||
| set_resp_headers(Map, Req); | ||
|
|
||
| set_resp_headers_list([{<<"set-cookie">>, _} | Headers], Map, Req) -> |
There was a problem hiding this comment.
@essen I wonder if to have some consistency with the set_resp_header we should instead throw an error. What do you say?
|
Integration tests will be added soon. I would like to get your thoughts first, @essen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1295