Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking consent #56

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

tracking consent #56

wants to merge 17 commits into from

Commits on Jul 31, 2020

  1. Configuration menu
    Copy the full SHA
    972e254 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d02971 View commit details
    Browse the repository at this point in the history
  3. TrackingConsent: turn public into static

    - turn public methods into static ones
    - turn "domain" prop into static const
    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    319669d View commit details
    Browse the repository at this point in the history
  4. TrackingConsent: PR requested changes - Multiple fix and improvements

    - PR requested changes
    - Listening for tab / window focus in case the user allows tracking on another tab / window or change browser settings / vpn
    
    ToDo:
    - Should use BottomOverlay
    - Component doc comment
    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    b376b81 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    758053e View commit details
    Browse the repository at this point in the history
  6. TrackingConsent: Add i18n

    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    f2216e6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3c78e70 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cb85d5a View commit details
    Browse the repository at this point in the history
  9. TrackingConsent: debug with dashboard & fixes

    - types fix
    - setTrackerUrl & trackingScriptUrl urls fix
    - add default setTrackerUrl value
    - now using a window `focus` listener instead of document `visibilitychange` one
    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    47c5a24 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2cd5ef4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ad9ea69 View commit details
    Browse the repository at this point in the history
  12. TrackingConsent: add api reference link for options / now supporting …

    …null and string[] as options value’s type
    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    0679b74 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ff10c36 View commit details
    Browse the repository at this point in the history
  14. TrackingConsent: Requested Changes

    PR #56
    Requested changes by Sisou
    #56 (review)
    
    - `options.setSiteId` doesn’t have a default value anymore, and is now required
    - Renamed `DEFAULT_TRACKING_URL` to `DEFAULT_TRACKING_SCRIPT_URL`
    - Moved the default `geoIpServer` value to a constant named `DEFAULT_GEOIP_SERVER_URL`
    - Added possibility to set the cookie's attributes `secure` and `sameSite`
    - Added a comment explaining the two `localStorage` keys
    - Changed default lifetime of the cookie from 20 years to 10 years since 20 years would not work on 32bits systems. (the cookie would just disappear instantly)
    mraveux committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    05cefe2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2020

  1. TrackingConsent: Multiple changes & fixes

    - now loading Matomo tracking script before checking for UI requirement, but disable cookie usage before user give consent (if in EEA)
    - removed `allowBrowserData` since we’re tracking browser data by default, without asking for consent
    - fixed `geoIpServer` @prop default value
    - now checking if `_paq` & `_mtm` are objects that have a `push` method, instead of checking if they’re Arrays (since they’re not Arrays, but objects with a single `push` method)
    - removed the public static getter `allowsBrowserData` and the public static method `allowBrowserData `
    - added a static public getter `isOutsideEEA`, since we can enable Cookies without consent for countries outside the EEA
    - turned the `execFunction` method into a async one, allowing to `await` for the function result
    mraveux committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    1980f33 View commit details
    Browse the repository at this point in the history
  2. TrackingConsent: trackPageView changes

    - add a `trackPageView` public static method for easy page tracking on single-page apps
    - set trackPageView by default to track first page view
    mraveux committed Aug 1, 2020
    Configuration menu
    Copy the full SHA
    05af0f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f841c32 View commit details
    Browse the repository at this point in the history