Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always require confirmation click when downloading LoginFile #424

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Always require confirmation click when downloading LoginFile #424

merged 4 commits into from
Apr 15, 2021

Conversation

sisou
Copy link
Member

@sisou sisou commented Mar 29, 2021

Replaces #423.

@sisou sisou added the enhancement New feature or request label Mar 29, 2021
@sisou sisou requested review from danimoh and mraveux March 29, 2021 11:21
@sisou sisou self-assigned this Mar 29, 2021
danimoh
danimoh requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@danimoh danimoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This PR does not implement the final design yet.
  • back-to-download is still referenced in Export.css and can be removed.

src/components/DownloadLoginFile.js Outdated Show resolved Hide resolved
src/components/DownloadLoginFile.js Outdated Show resolved Hide resolved
src/translations/fr.json Outdated Show resolved Hide resolved
src/components/DownloadLoginFile.js Show resolved Hide resolved
mraveux
mraveux approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@mraveux mraveux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective. Nice 👍
I would've loved to have a transition between the buttons, with the text fading out or smth. But i guess that since we're opening a popup the "jump" is not meant to be seen so we don't really need one.

danimoh
danimoh approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@danimoh danimoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I agree with Matheo that animating between the two states would be nice.
Note that not always a popup dialogue is opening, specifically if the user has his browser setup to download files immediately.
In this case he'd be seeing the animation.

For the fallback-download case I would personally not unveil the Continue text in the continue button as it breaks the layout to a degree.

@sisou sisou force-pushed the soeren/loginfile-download-confirmation branch from 634d11a to edac524 Compare April 15, 2021 07:25
@sisou sisou merged commit 3d1cbd1 into master Apr 15, 2021
@sisou sisou mentioned this pull request Apr 15, 2021
Open
@sisou sisou deleted the soeren/loginfile-download-confirmation branch April 15, 2021 07:29
@sisou
Copy link
Member Author

sisou commented Apr 15, 2021

I created issue #426 for the button transitions, as it's too much work now to figure this out and not worth the delay in releasing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariofriz mariofriz mariofriz left review comments

@danimoh danimoh danimoh approved these changes

@mraveux mraveux mraveux approved these changes

Assignees

@sisou sisou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sisou @mariofriz @danimoh @mraveux