Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace tw with unocss #8

Closed
wants to merge 34 commits into from
Closed

replace tw with unocss #8

wants to merge 34 commits into from

Conversation

onmax
Copy link
Member

@onmax onmax commented Apr 15, 2024

No description provided.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for nimiq-map failed.

Name Link
🔨 Latest commit d403371
🔍 Latest deploy log https://app.netlify.com/sites/nimiq-map/deploys/663a39e30c6de30008f8dcc0

@onmax onmax marked this pull request as ready for review May 7, 2024 06:37
@onmax onmax requested a review from Albermonte May 7, 2024 06:38
@Albermonte
Copy link
Collaborator

The X in the modal's close button is not centered
image

For consistency, I will fill the lightning with a white bg
image

The Nimiq icon is not centered
image

Zooming to more than 14z causes all markers to disappear.

The cuttlery icon seems too big/not centered
image

Hovering ATM markers causes bg to disappear
image

<template v-else-if="location.accepts.length > 0">{{ $t('Sell crypto only') }}</template>
<template v-else-if="location.sells.length > 0">{{ $t('Buy crypto only') }}</template>
</span>
<p v-if="location.address" leading-18 :grid="`~ cols-1 row-start-3 ${location.photo ? 'col-span-2' : 'col-span-3'}`"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a grid if the content is only text?

Copy link
Member Author

@onmax onmax May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Not needed. probably copy 🍝

@onmax
Copy link
Member Author

onmax commented May 8, 2024

@Albermonte fyi, the 15z it is caused by the new providers. Oopsie, I will fix it Fixed it

Error fetching database: 400 . Response {}. Data {"code":"42804","details":"Returned type provider_type does not match expected type text in column 8.","hint":null,"message":"structure of query does not match function result type"}

@onmax
Copy link
Member Author

onmax commented May 8, 2024

The Nimiq icon is not centered

Fun fact. It is not the Nimiq Icon, it is the Nimiq Pay Icon. I need to set the background color 🤓

@onmax
Copy link
Member Author

onmax commented May 8, 2024

Thanks for you feedback. I will move this to #9

@onmax onmax closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants