Use argon2id by default #2377
Merged
Use argon2id by default #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paberr
force-pushed
the
pb/argon2
branch
2 times, most recently
from
4a29346
to
f19ed89
Compare
jsdanielh
approved these changes
Apr 17, 2024
|
It seems argon2id spends some of its time trying to defeat memory-access based side channel attacks ("side channel protection"). I agree that this sounds useful. |
|
Rebasing to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Replaces
argon2dwithargon2idwhile remaining backwards compatible with existing wallets.argon2idhas additional side-channel protection.Pull request checklist
clippyandrustfmtwarnings.