Sanity Check proposal sender from proposal messages #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibhar
force-pushed
the
nibhar/proposal_sender
branch
2 times, most recently
from
1c641b3
to
18b9c31
Compare
jsdanielh
approved these changes
Apr 25, 2024
hrxi
force-pushed
the
nibhar/proposal_sender
branch
from
18b9c31
to
cbb72c8
Compare
|
Rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR a proposal message can contain an out of bounds sender. When trying to retrieve the validator to that sender the node would panic.
This PR fixes that and adds some documentation regarding panics to the relevant function in this context.
Fixes #2322.