-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Refactor design matrix and contrast formula for the two-sample T-test example #4407
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
10074a6
Refactor design matrix and update contrast formula for the two-sample…
YCHuang0610 9adf410
[FIX] Refactor design matrix and contrast formula for two-sample t-te…
YCHuang0610 a07ceea
Solve rank-deficien design matrix for paired-design
YCHuang0610 d59cabd
Refactor design matrix and correct the paired design matrix to become…
YCHuang0610 da3c572
Modify the comment in plot_second_level_two_sample_test.py
YCHuang0610 7706fb0
Modified the comment paragraph in plot_second_level_two_sample_test.py
YCHuang0610 73796e9
Merge branch 'main' into main
Remi-Gau 7091877
formatting fix through tox
YCHuang0610 e33eab1
Merge branch 'main' of https://github.com/YCHuang0610/nilearn
YCHuang0610 0a55003
Merge branch 'main' into main
man-shu 86ee1d6
Add author information and change logs
YCHuang0610 add851d
Merge branch 'main' of https://github.com/YCHuang0610/nilearn
YCHuang0610 f005d95
add author information (Sort alphabetically.)
YCHuang0610 3241189
add newline at end of file
YCHuang0610 ebd919b
fix label for example
man-shu bd3622c
add `.py` in the example reference
man-shu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should have been clearer, but when you do this you make the design matrix rank deficient: the sum of these two regressors, is equal to the some of all the subject regressors.
This means that the design matrix is no longer invertible, and some contrasts are not estimable. Normally, you should get a warning when you run that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that mistake for the paired design matrix.
Now I have modified the paired design matrix as follows:
which rank is 17.
The unpaired design matrix is now added a intercept column as follows:
Its rank is 2 which is a full column rank matrix.