New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add comparison of meaning differences of GLM between different libraries #4287
base: main
Are you sure you want to change the base?
Conversation
👋 @tpremrud Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Co-authored-by: Taylor Salo <tsalo90@gmail.com>
Co-authored-by: Taylor Salo <tsalo90@gmail.com>
Thanks for starting this @tpremrud: I can already tell this will be usefull! Couple of general comments. I would suggest mentioning that we use the BIDS definitions of "run" in this document (and in general we are trying to move to make this use consistent in nilearn). Also as far as I can tell all the mentions of the word "session" in your text should be replaced by "run". https://bids-specification.readthedocs.io/en/latest/common-principles.html#definitions
I do not think we need the whole definition but at least the main bit and then a link to the BIDS glossary: |
SPM uses the same notation as nilearn for analysis levels, with a note that a session still refers to an imaging session or a run, and within a run there could be multiple conditions (e.g., congruent and incongruent). | ||
In this case, `SPM`_ provided `tutorials`_ and documentation, including `lectures`_, which one could learn to analyze their own fMRI data with the meaning of analysis levels being as follows: | ||
|
||
* `First-level analysis in SPM`_: Analyze across sessions for a subject (i.e., more than one session of one subject) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that we should mention somewhere that it is typical in the SPM workflow to put all runs in a single design matrix, where as nilearn typically will give you one design matrix per run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha @Remi-Gau , that's a really great point! However, I'm wondering if I understand the concept correctly, so if there are different conditions, do they still count as a single run if the imaging acquisition is continuous, uninterrupted, and comprise of the same parameters?
I'm looking at nilearn example it seems like there are different conditions within a design matrix, but you said that nilearn gives one design matrix per run, so I'm just not sure if I understand the concept of run correctly as I should or not.
But the SPM really does have a design matrix that goes through all the runs in one matrix.
Thank you!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4287 +/- ##
==========================================
+ Coverage 91.85% 92.12% +0.27%
==========================================
Files 144 143 -1
Lines 16419 16438 +19
Branches 3434 3444 +10
==========================================
+ Hits 15082 15144 +62
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes proposed in this pull request:
meaning_difference.rst
as a documentation file for comparing GLM analysis levels between different libraries (i.e., FSL and SPM)meaning_difference.rst
page.Note: I am still uncertain if some of the wording and content are redundant (e.g., runs vs sessions, which I am certain are the same, but I included for clarity); please feel free to make any suggestions! :)